fix(core): surface API error detail and the failing endpoint URL#1619
Merged
Conversation
JulianMaurin
temporarily deployed
to
func-tests-live
GitHub Actions
Inactive
This was referenced Jun 16, 2026
Contributor
Author
|
This pull request is part of a Mergify stack:
|
Contributor
Merge Protections🟢 All 6 merge protections satisfied — ready to merge. |
JulianMaurin
force-pushed
the
devs/JulianMaurin/fix/stack-push-output/surface-api-error-detail-failing-endpoint-url--76d98c2d
branch
from
643363e to
4396d07
Compare
JulianMaurin
force-pushed
the
devs/JulianMaurin/fix/stack-push-output/restore-prefix-match-error-detail-found-exit-codes--52793895
branch
from
266f9bb to
2675a1a
Compare
Contributor
Author
Revision history
|
JulianMaurin
temporarily deployed
to
func-tests-live
GitHub Actions
Inactive
JulianMaurin
temporarily deployed
to
func-tests-live
GitHub Actions
Inactive
This was referenced Jun 17, 2026
Ambiguous <COMMIT> resolution lost the "ambiguous" wording, the match count, each candidate's Change-Id, and used a 7-char SHA instead of 12. A no-match note target returned InvalidState (exit 7) instead of StackNotFound (3), and `stack open` on an empty stack exited 0 instead of 3, breaking $?-based detection. Add a shared match_commit helper (one copy of the Python reorder.py wording) used by drop/squash/fixup/edit/move/reword/reorder/note, and fix the two exit codes. Also restore the remediation guidance Python printed: the `targets itself` error (sync/push/list) regains the remote URL and both `git branch` fix commands, and the trunk-not-resolvable error regains the concrete `--set-upstream-to` hint. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Change-Id: I527938955f9a8b683f5c172d330a9faaea4517d5
HTTP error rendering dumped the raw response body — so a Mergify API `{"detail": "..."}` envelope reached the user verbatim — and never showed which URL failed. Extract the JSON `detail` field when present (falling back to the raw body), and append a trailing `url:` line on HTTP errors plus the contacted URL on network/timeout errors, matching the Python check_for_status output.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: I76d98c2d9a91d6ba5ad1747c91c56d4e1ade869f
JulianMaurin
force-pushed
the
devs/JulianMaurin/fix/stack-push-output/surface-api-error-detail-failing-endpoint-url--76d98c2d
branch
from
4396d07 to
e403d28
Compare
JulianMaurin
force-pushed
the
devs/JulianMaurin/fix/stack-push-output/restore-prefix-match-error-detail-found-exit-codes--52793895
branch
from
2675a1a to
6885975
Compare
JulianMaurin
temporarily deployed
to
func-tests-live
GitHub Actions
Inactive
JulianMaurin
temporarily deployed
to
func-tests-live
GitHub Actions
Inactive
Base automatically changed from
devs/JulianMaurin/fix/stack-push-output/restore-prefix-match-error-detail-found-exit-codes--52793895
to
main
June 18, 2026 07:59
jd
approved these changes
Jun 18, 2026
kozlek
approved these changes
Jun 18, 2026
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Contributor
Merge Queue Status
This pull request spent 10 minutes 21 seconds in the queue, including 7 minutes 10 seconds running CI. Required conditions to merge
|
38 tasks
mergify
Bot
deleted the
devs/JulianMaurin/fix/stack-push-output/surface-api-error-detail-failing-endpoint-url--76d98c2d
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP error rendering dumped the raw response body — so a Mergify API
{"detail": "..."}envelope reached the user verbatim — and never showed which URL failed. Extract the JSONdetailfield when present (falling back to the raw body), and append a trailingurl:line on HTTP errors plus the contacted URL on network/timeout errors, matching the Python check_for_status output.Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
Depends-On: #1618